Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated hgroup disclaimer #32214

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Remove outdated hgroup disclaimer #32214

merged 2 commits into from
Feb 14, 2024

Conversation

thibaudcolas
Copy link
Contributor

Description

This reverts commit fbb5b30, and removes the problematic disclaimer about <hgroup> from the Content categories page.

Motivation

In #18530 in July 2022, the disclaimers were removed, but only from the hgroup page. I suspect the Content categories page was missed. Then in December 2023, #30856 copies the outdated note from Content categories back to the hgroup page. I don’t think that disclaimer should have been there on any page, per the description of #32213:

The <hgroup> element was recently significantly revised in the HTML specification. The warnings about its impact on the outline algorithm are no longer relevant, as the concept of the outline algorithm was removed from the HTML specification as well.

This PR simply removes outdated content, and replaces the remaining bits with content that is more inline with the current definition for the element.

Additional details

See WHATWG Sections – the hgroup element

Related issues and pull requests

See #11153 for the initial rationale on removing those disclaimers.

@thibaudcolas thibaudcolas requested a review from a team as a code owner February 11, 2024 10:54
@thibaudcolas thibaudcolas requested review from estelle and removed request for a team February 11, 2024 10:54
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs size/xs [PR only] 0-5 LoC changed labels Feb 11, 2024
@thibaudcolas thibaudcolas force-pushed the remove-hgroup-disclaimer branch from 43d9cfa to d1e9229 Compare February 11, 2024 10:55
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 11, 2024 •
edited
Loading

Preview URLs

External URLs (1)

URL: /en-US/docs/Web/HTML/Content_categories
Title: Content categories

(comment last updated: 2024-02-11 10:56:11)

@thibaudcolas thibaudcolas mentioned this pull request Feb 11, 2024
Merged
estelle
estelle approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@estelle estelle merged commit b46c03e into mdn:main Feb 14, 2024
8 checks passed
@thibaudcolas thibaudcolas deleted the remove-hgroup-disclaimer branch February 15, 2024 21:54
@Josh-Cena Josh-Cena mentioned this pull request Jul 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

Assignees
No one assigned
Labels
Content:HTML Hypertext Markup Language docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thibaudcolas @estelle